Skip to content

Commit

Permalink
ft4: Fix incorrect DTCS handling
Browse files Browse the repository at this point in the history
This driver has been broken forever in how it handles DTCS tone mode.
It was always using the rx_dtcs field, which should only be honored
in a ->DTCS cross mode. The new GUI, being in hide-unused-fields mode
always made this clear, as it appeared to be snapping back to 023
always when the user selected a different value.

Note that the test is *also* broken, which I will fix at the end of
this series.

Related to #11506
  • Loading branch information
kk7ds committed Aug 30, 2024
1 parent 0375bc6 commit b9190ce
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chirp/drivers/ft4.py
Original file line number Diff line number Diff line change
Expand Up @@ -1030,7 +1030,7 @@ def encode_sql(self, mem, chan):
if mem.tmode == "TSQL":
chan.tx_ctcss = chan.rx_ctcss # CHIRP uses ctone for TSQL
if mem.tmode == "DTCS":
chan.tx_dcs = chan.rx_dcs # CHIRP uses rx_dtcs for DTCS
chan.rx_dcs = chan.tx_dcs # CHIRP uses rx_dtcs for DTCS
# select the correct internal dictionary and key
mode_dict, key = [
(TONE_DICT, mem.tmode),
Expand Down

0 comments on commit b9190ce

Please sign in to comment.