Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup rpttool #1031

Merged
merged 1 commit into from
May 14, 2024
Merged

Fixup rpttool #1031

merged 1 commit into from
May 14, 2024

Conversation

cmlara
Copy link
Contributor

@cmlara cmlara commented May 11, 2024

Fix idrp python3 conversion

Fixes #11252

Co-Authored-By: Dan Smith dsmith@danplanet.com

Copy link
Owner

@kk7ds kk7ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cpep8 manifest complaint looks incorrect. The rest of this looks good to me. Still draft because you're still working on it, or what? If you respin, please put "Fixes #11252" in one (or all) of the commit messages so that it gets tagged to the bug. It has to be that pattern or the bug tracker won't notice. I'll try to remember to do it myself before I merge if this is ready.

Either way we just had a build today so I'll hold off merging for a few days.

Thanks!

chirp/drivers/idrp.py Show resolved Hide resolved
@kk7ds
Copy link
Owner

kk7ds commented May 11, 2024

See if that works or gets you close. That function is obsolete for everything else other than idrp, so it never got fixed for py3.

@kk7ds
Copy link
Owner

kk7ds commented May 11, 2024

Ah, PR check fail was because it wasn't rebased on master and cpep8.manifest was trimmed between what you were based on and current.

@cmlara
Copy link
Contributor Author

cmlara commented May 11, 2024

I have to attend a family event, however I was able to run a quick test with your latest change and rpttool reports successfully changing the frequency.

I can return this evening to cleanup the commit messages and do any other fix-up work you might want.

@kk7ds
Copy link
Owner

kk7ds commented May 11, 2024

Cool, glad to hear it. I think we should just squash this into one "fix idrp" commit with the proper bug reference and I'll get it merged sometime next week. So, no rush and/or I can just do it for you.

Thanks much!

Fixes #11252

Co-Authored-By: Dan Smith <dsmith@danplanet.com>
@cmlara cmlara marked this pull request as ready for review May 12, 2024 02:32
@cmlara
Copy link
Contributor Author

cmlara commented May 12, 2024

Cleaned up the commit message and squashed. Thanks for the help with the bcd_encode portion to finish this up.

No rush on the merge, take it at your leisure.

@kk7ds kk7ds merged commit 3fed8b4 into kk7ds:master May 14, 2024
6 checks passed
@cmlara cmlara deleted the fixup_rpttool branch May 14, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants