Add support for KSUN M6 #1060
Merged
Add support for KSUN M6 #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavexx
force-pushed
the
ksun_m6
branch
5 times, most recently
from
3dff287
to
c541c32
Compare
kk7ds
reviewed
Jun 7, 2024
chirp/drivers/ksun_m6.py
Outdated
| serial = radio.pipe | ||
|
|
||
| addr = struct.pack(">H", block_addr) | ||
| cmd = b"R" + addr |
There was a problem hiding this comment.
Just a nit, but might as well, let struct pack the command too:
struct.pack(">BH", b"R", addr)
chirp/drivers/ksun_m6.py
Outdated
| + (_mem.freq[3] << 8) + _mem.freq[4]) | ||
|
|
||
| mem.freq = int(rx_freq / 2000 * 1000000) | ||
| mem.offset = int(tx_freq / 2000 * 1000000) |
There was a problem hiding this comment.
Use // which is integer division and then you won't need the int() cast.
| tx_freq = rx_freq | ||
|
|
||
| rx_freq = round(rx_freq / 1000000 * 2000) | ||
| tx_freq = round(tx_freq / 1000000 * 2000) |
There was a problem hiding this comment.
This is intentional so that the target frequency is snapped to the closest representation and not to the lowest representable integer. This is something that bugs me with most other drivers.
Fixes #11348
|
Rebased, squashed and tagged the issue (per the guidelines) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the KSUN M6 (https://it.aliexpress.com/item/1005005096348552.html).
I've been working this on-an-off in the past months and it's my first attempt, so I apologize if that's not perfect. I only have one of these radios at my disposal so my testing is limited to this specific sample I have.
The radio can be purchased with the cable (just a regular baofeng-to-usb ch341-uart driver), but came with no software. The "official" website download (http://www.qzksun.com/index.php?m=content&c=index&a=lists&catid=37) doesn't work. I've been comparing the results with the "LED Radio program 1.03" software which I was able to find on some forums after extensive searching, which doesn't seem the most recent version. It only works on windows, fails to do anything about 70% of the time I run it, and it's absolutely horrifying to use which is what prompted me to write this driver.
All the channel memory features are supported (all tone/dtcs/cross modes), including the "hopping/compander/scrambler" features. All settings, with the exception of the "password", are supported too.
There are still some unexplained fields in the settings/channel memory. A few bytes could be explained by the password field, but the rest is a mystery. I've seen screenshots of a more recent version of the original software, but I couldn't get my hands on it to actually reverse it.