ksun_m6: Fix initialization of new memories #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly set a few extra bits to zero to initialize correctly new memory slots. _unk3/_unk4 seem to be part of compander/hopping respectively, even though only a single value for both is accepted. Setting _unk3 to 1 (compander:0b10) makes the radio ignore the channel completely. The original software also refuses to decode the slot and fail with a generic error. Setting _unk4 to 1 (hopping:0b10) works on the radio, but still causes the original software to fail with an error.
|
Thanks, sorry this took so long to be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly set a few extra bits to zero to initialize correctly new memory slots.
_unk3/_unk4 seem to be part of compander/hopping respectively, even though only a single value for both is accepted.
Setting _unk3 to 1 (compander:0b10) makes the radio ignore the channel completely. The original software also refuses to decode the slot and fail with a generic error.
Setting _unk4 to 1 (hopping:0b10) works on the radio, but still causes the original software to fail with an error.