Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RT490: Add supported charset #1088

Closed
wants to merge 2 commits into from
Closed

RT490: Add supported charset #1088

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd94d0b
Update radtel_rt490.py
pbarrette Aug 15, 2024
b1f425c
Update radtel_rt490.py
pbarrette Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions chirp/drivers/radtel_rt490.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,9 @@ class RT490Radio(chirp_common.CloneModeRadio):
(0x3FC0, 0x4000)
]

_valid_chars = chirp_common.CHARSET_ALPHANUMERIC + \
"`~!@#$%^&*()-=_+[]\\{}|;':\",./<>?"

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't used anywhere so this won't have any effect. I assume you want to set valid_characters in get_features() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yet it works, so I don't know what to tell you.

I took the example directly from mml_jc8810.py

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really doesn't. I changed it to just 'a' and I can still put in names like "FOO". With and without your patch, I can only put in uppercase characters.

The mmp_jc8810.py actually references it exactly where I said, which is why it works there and does not work here:

https://github.com/kk7ds/chirp/blob/master/chirp/drivers/mml_jc8810.py#L470

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, crap. I clearly missed that while I was trying to not re-contaminate with the NEEDS_COMPAT_SERIAL that still existed in my original file.

if RT490_EXPERIMENTAL:
# Experimental driver (already heavily tested)
_ranges = [(0x0000, 0x2400), (0x3400, 0x3C40), (0x3F80, 0x4000)]
Expand Down
Loading