Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver - UVk5 - ctss & dtcs codes match common, reference common instead of redefining. #1092

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

ei2081
Copy link
Contributor

@ei2081 ei2081 commented Aug 16, 2024

This is a minor update to re-use chirp_common code ctcss/dtcs definitions rather than duplicating.
I assume this is preferred.

@ei2081 ei2081 changed the title Uvk5 ctss dtcs codes match common driver - UVk5 - ctss & dtcs codes match common, reference common instead of redefining. Aug 16, 2024
@kk7ds
Copy link
Owner

kk7ds commented Aug 17, 2024

Yep, thanks, but please squash this into one commit with a good commit message first line for the build announcement. Use git rebase -i, squash them all, update the commit message, then git push -f to update this PR.

Thanks!

@ei2081 ei2081 force-pushed the uvk5-ctss-dtcs-codes-match-common branch from 572f53b to dfbf2b0 Compare August 17, 2024 18:54
@ei2081
Copy link
Contributor Author

ei2081 commented Aug 17, 2024

think i got it with a little further help from so but out of my usual comfort zone with git there :D

update uvk5 driver to reference chirp_common ctcss and dtcs codes instead of duplicating
@kk7ds kk7ds force-pushed the uvk5-ctss-dtcs-codes-match-common branch from dfbf2b0 to 0311bb1 Compare August 20, 2024 21:44
@kk7ds kk7ds merged commit 63be12a into kk7ds:master Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants