Icom IC-9700 Support #1094
Merged
Icom IC-9700 Support #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kk7ds
commented
Aug 22, 2024
kk7ds
commented
- Use a global job lock for live multi-dev radios
- Fix memedit extra expansion with live radios
- Add Icom IC-9700 support
kk7ds
force-pushed
the
ic9700
branch
3 times, most recently
from
4d8c886
to
f9a852d
Compare
This allows LiveRadio drivers to use the single serial connection as if it has exclusive access by making sure that only one RadioJob runs at any given time. This could potentially reduce performance if you were doing lots of operations against multiple live radios at once, and we could improve that later. However, it makes writing LiveRadio drivers with multiple sub_devices much more straightforward.
Since live radios don't have a comment column (even with metadata simulation) we cannot assume it is there for calculating the index for extra columns.
Note this does not implement any D-STAR stuff or satellite memories yet, it's just basic support. Fixes #10018
This is sort of an approximation as we don't have a good way to support pairs of full memories stored together, but it's probably close enough. Related to #10018
Fixes #11459 Fixes #11259
These radios (annoyingly) treat frequencies in airband as AM, which really isn't how chirp was designed to work. Before, we were making them immutable, but that brings all sorts of problems with it. Instead, coerce the values on get/set, and return a warning from validate_memory() so the user is warned. In reality, we should probably be doing that more places where we have immutable fields, where the immutable-ness depends on the content of the memory (i.e the frequency) than the location. Fixes: #11441
This prevented import_mem from working and thus paste (!) Fixes #11455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.