Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icom IC-9700 Support #1094

Merged
merged 8 commits into from
Aug 25, 2024
Merged

Icom IC-9700 Support #1094

merged 8 commits into from
Aug 25, 2024

Conversation

kk7ds
Copy link
Owner

@kk7ds kk7ds commented Aug 22, 2024

  • Use a global job lock for live multi-dev radios
  • Fix memedit extra expansion with live radios
  • Add Icom IC-9700 support

@kk7ds kk7ds force-pushed the ic9700 branch 3 times, most recently from 4d8c886 to f9a852d Compare August 25, 2024 00:44
This allows LiveRadio drivers to use the single serial connection as
if it has exclusive access by making sure that only one RadioJob runs
at any given time. This could potentially reduce performance if you
were doing lots of operations against multiple live radios at once,
and we could improve that later. However, it makes writing LiveRadio
drivers with multiple sub_devices much more straightforward.
Since live radios don't have a comment column (even with metadata
simulation) we cannot assume it is there for calculating the index for
extra columns.
Note this does not implement any D-STAR stuff or satellite memories
yet, it's just basic support.

Fixes #10018
This is sort of an approximation as we don't have a good way to
support pairs of full memories stored together, but it's probably
close enough.

Related to #10018
Fixes #11459
Fixes #11259
These radios (annoyingly) treat frequencies in airband as AM, which
really isn't how chirp was designed to work. Before, we were making
them immutable, but that brings all sorts of problems with it. Instead,
coerce the values on get/set, and return a warning from
validate_memory() so the user is warned.

In reality, we should probably be doing that more places where we have
immutable fields, where the immutable-ness depends on the content of
the memory (i.e the frequency) than the location.

Fixes: #11441
This prevented import_mem from working and thus paste (!)

Fixes #11455
@kk7ds kk7ds merged commit 97d64b2 into master Aug 25, 2024
6 checks passed
@kk7ds kk7ds deleted the ic9700 branch August 25, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant