rt22: Fix tones not being enabled #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memories that chirp edits from scratch ended up with more unknown bits set, which interfered with the enabling of tones. This makes us clear the memory to zero first (which appears to be the way other software does it) and also set one of the unknown bits to a known value. Fixes #11451
kk7ds
force-pushed
the
bug/11451/rt22tone
branch
from
c372fa2
to
b54cebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memories that chirp edits from scratch ended up with more unknown
bits set, which interfered with the enabling of tones. This makes us
clear the memory to zero first (which appears to be the way other
software does it) and also set one of the unknown bits to a known
value.
Fixes #11451