Tuning step fixes #1115
Merged
Tuning step fixes #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kk7ds
commented
Sep 10, 2024
kk7ds
commented
- Fix several drivers with zero tuning steps
- Prioritize radio-supplied tuning steps
The valid_tuning_steps must be ... valid.
The ft1d driver has seemingly had incorrect tuning step handling since the beginning. As a result, stricter handling of tuning steps provided by the radio started to break down. This fixes them to work according to the OEM software for all the available steps.
This makes the UI consider the radio's tuning steps, if defined as the first course of action. The existing code tried the standard set followed by the radio's set, assuming the radio's would be a subset, which is of course not always true. This also makes required_step() consider the radio-specific steps after the standard ones, if there are any strange ones to allow the radio to define ones that are not in the standard list. Related to #10968
kk7ds
force-pushed
the
fix-tuning-steps
branch
from
7a62d71
to
99cfeae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.