Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retevis RB27: support full band TX/RX - fixes #10686 #693

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

KC9HI
Copy link
Contributor

@KC9HI KC9HI commented Jun 30, 2023

CHIRP PR Checklist

The following must be true before PRs can be merged:

  • All tests must be passing.
  • Commits should be squashed into logical units.
  • Commits should be rebased (or simply rebase-able in the web UI) on current master. Do not put merge commits in a PR.
  • Commits in a single PR should be related.
  • Major new features or bug fixes should reference a CHIRP issue.
  • New drivers should be accompanied by a test image in tests/images (except for thin aliases where the driver is sufficiently tested already).

Please also follow these guidelines:

  • Keep cleanups in separate commits from functional changes.
  • Please write a reasonable commit message, especially if making some change that isn't totally obvious (such as adding a new model, adding a feature, etc).
  • Do not add new py2-compatibility code (No new uses of six, future, etc).
  • All new drivers should set NEEDS_COMPAT_SERIAL=False and use MemoryMapBytes.
  • New drivers and radio models will affect the Python3 test matrix. You should regenerate this file with tox -emakesupported and include it in your commit.

@@ -751,8 +751,7 @@ class TestOverrideRules(base.BaseTest):
'Radioddity_DB25-G',
'Retevis_RA85',
'Retevis_RA685',
'Retevis_RB17P',
'Retevis_RB27',
'Retevis_RB17P'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change this, but if you always make these end with a trailing comma, you can add and remove items from the list with only one line of change. It's an OCD thing :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. The only reason I removed it was because you told not to do it on something else. Must have been in a different context. I agree, I find the trailing comma handy in this case.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably on a function call. It's technically allowed there too, but very unconventional. Something like:

some_thing(foo, bar,)

or on single-line lists:

foo = [1, 2, ]

is not generally done. But multi-line lists it's better to keep the trailing comma, just because each one is a line, and you end up having to make less change to add/remove things.

But as you can see, its importance is pretty microscopic :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I recall, I believe that you are exactly right. Got it. Thanks!

@kk7ds kk7ds merged commit 634249a into kk7ds:master Jun 30, 2023
6 checks passed
@KC9HI KC9HI deleted the rb27b-series-full-band branch July 6, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants