Ensure exclusive access to radios per editorset #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A ChirpLiveEditorSet represents a conversation with a single radio endpoint, but may involve multiple independent event streams. We really don't need multiple threads and queues for talking to a single radio, however radios with multiple sub-devices will end up with different Radio classes by nature. So, instead of collapsing editors into a single thread, we can just make them share a lock, established at the EditorSet level, which is what this patch does. This also means the other drivers (that I know of) that do their own locking (kenwood_live, kenwood_d7, because settings) and ic9x (because multiple sub-devices) can simplify and rely on this being handled in the UI. Related to #10683
|
FYI @W8BSD this should make any threads for a single radio exclusive so we don't try to have more than one simultaneous conversation with the radio at a time. I've tested on a D700 for your new module, a TM-281 to confirm kenwood_live, and an IC-92 to get the other one. If you have a chance to look this over and/or test before we merge, that'd be cool. No rush since it's just cleanup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ChirpLiveEditorSet represents a conversation with a single radio
endpoint, but may involve multiple independent event streams. We
really don't need multiple threads and queues for talking to a single
radio, however radios with multiple sub-devices will end up with
different Radio classes by nature. So, instead of collapsing editors
into a single thread, we can just make them share a lock, established
at the EditorSet level, which is what this patch does.
This also means the other drivers (that I know of) that do their
own locking (kenwood_live, kenwood_d7, because settings) and ic9x
(because multiple sub-devices) can simplify and rely on this being
handled in the UI.