Add warnings and volatile flag to settings #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KC9HI FYI, this is what I was thinking for "careful with this setting" warning dialogs. I haven't tested this on windows yet, but here it is. I made the modified firmware toggle for the UV-K5 use it. We should probably similarly warn for other settings where the user can cause mayhem by changing it. |
This adds two functions for settings. A warning message can be added, which will either always be displayed to the user when they change the value, or only when they change it away from some default. They are given the opportunity to cancel the change if the warning makes them reconsider. Also, a setting can be marked "volatile" which will cause the settings tab to be fully reloaded when it has been changed. This resets the view as well, so it's not ideal, but this can be used when one setting necessarily impacts another. Fixes #10695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two functions for settings. A warning message can be added,
which will either always be displayed to the user when they change the
value, or only when they change it away from some default. They are
given the opportunity to cancel the change if the warning makes them
reconsider.
Also, a setting can be marked "volatile" which will cause the settings
tab to be fully reloaded when it has been changed. This resets the
view as well, so it's not ideal, but this can be used when one setting
necessarily impacts another.