Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save backup images after every download #698

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Save backup images after every download #698

merged 2 commits into from
Jul 3, 2023

Conversation

kk7ds
Copy link
Owner

@kk7ds kk7ds commented Jul 2, 2023

This makes us save a backup image of every radio we download from
in the CHIRP profile directory, under backups/. This will help people
who don't capture a first-time download image from their radio, as
well as people who make some change that they end up not liking.

We'll need to prune these somehow going forward, but that can be done
later.

@kk7ds
Copy link
Owner Author

kk7ds commented Jul 2, 2023

@KC9HI Thoughts on this? This might help with the "I hope you kept a pristine copy of your radio before you did something bad" problems right? Original idea from @goldstar611 a while back, but the recent rash of issues makes me think it's worth it.

I could make chirp automatically prune anything more than 365 days old, or maybe as much as necessary to keep ithe backup directory under 100MB or something.

@kk7ds
Copy link
Owner Author

kk7ds commented Jul 2, 2023

Okay, made it prune at 365 days, configurable by hidden setting in chirp.config.

This makes us save a backup image of every radio we download from
in the CHIRP profile directory, under backups/. This will help people
who don't capture a first-time download image from their radio, as
well as people who make some change that they end up not liking.

Keep a year (by default) of backup images, which can be changed in
the config file.

Fixes #10694
Require GPLv3 license and check for violations.
@kk7ds kk7ds merged commit d9a8f48 into master Jul 3, 2023
6 checks passed
@kk7ds kk7ds deleted the save-backups branch July 3, 2023 03:40
@goldstar611
Copy link
Contributor

This is awesome. It won't help out if you download one then upload to many radios (one of my original hesitations on sending a patch earlier this year) but I think it will definitely help out in other cases like when manufacturers update the firmware years later without changing the radio ident for example.

@kk7ds
Copy link
Owner Author

kk7ds commented Jul 3, 2023

Yeah, won't help if you have never downloaded a radio and upload to it blindly, but there's not much we can do about that. But, if you have two and have ever downloaded both, at least there's a hope of finding one of the original ones for the radio you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants