Add subclass for Baofeng's 1900 series #700
Conversation
|
Thanks for this, but it's very little delta from the |
|
Let me take a shot at it, thank you Dan. |
There was a problem hiding this comment.
Great, thanks very much! Here are some hints to get you started. Also, please include a test image in tests/images for the radio to exercise the new subclass. You're welcome to put it into the h777.py file, or keep your baofeng_1900.py file and just import h777 so you can subclass.
cetinajero
changed the title
|
Thanks for your guidance Dan, WIP yet. Still pending tasks:
|
|
Looks pretty close, that was fast :) |
| VENDOR = "Baofeng" | ||
| MODEL = "BF-1904" | ||
| ALIASES = [] | ||
|
|
There was a problem hiding this comment.
Do you want separate power levels for this? I think this is the 10W unit? Not a huge deal, but it should be easy.
There was a problem hiding this comment.
Different power levels but same subset of features... what do you suggest?
There was a problem hiding this comment.
It would be better to have different power levels exposed by that driver so that when importing memories it selects the closest one. You can just do the same thing you did for the VALID_BANDS but with a list of power levels.
|
Just need to fix the style things to be mergeable. Also, can you fix up the commit message? I think it still has content from a previous commit in it. Also put "Fixes: #8551" in the commit message so the bug system will close that bug and point to this when it merges. Looks great otherwise. I can rebase for you when ready, if it helps. |
|
Yes, I'm running with Is there an auto fix style option? I plan to add 3 total commits (other two for the scan list struct and alarm option list), is that ok? |
No, but I can fix for you if needed.
Sure. However, I'm going to be unavailable for the next week starting tomorrow. How about we just get this merge-able now and you can follow up with the extra features later? |
|
Ok, almost there |
|
It should be mergeable by now Dan, let me know your thoughts. |
|
Looks good to me. Can I tweak your commit message for the first commit to reference the bug? Other than that I'm good. |
|
Oh yeah, I forgot that. I can just amend it. |
Fixes: #8551 ``` python3 -mpip install tox tox -e unit tox -e makesupported tox -e style ```
Also add POWER_LEVELS of 10 watts to BF1904, important to note that it only supports low and high as options.
The settings2 struct wasn't pointing to the right address, Baofeng decided to remove the programmable side key function and used that reserved address to add the "Search" scan mode option (having 3 scan options requires more than 1 memory bit). This was debugged by using the original Baofeng software (BF_1901_FH) and comparing back and forth.
|
Also, I assume we want to tell users with a BF-1902 to use BF-1901 right? There's mapping in the code that will update the website after merge so it says "BF-1902 (use BF-1901)". |
Related to #8551
Yeah, that will be helpful, where can we add those relationships? |
|
I added it here, to |
|
Awesome, thanks Dan! It was great working on this |
|
Excellent thanks very much! |
Hello,
Currently Chirp doesn't support the Baofeng BF-1900 series, this PR was created to support them, including:
The PR updates the settings2 struct to reflect the scan mode options used by this models.
Baofeng decided to remove the programmable side key function and used that reserved address to add the "Search" scan mode option (having 3 scan options requires more than 1 memory bit).
My testing and debugging was based on the original Baofeng software (BF_1901_FH) and comparing back and forth.
Fixes: #8551
✌🏼