Multiple UI fixes #717
Merged
Multiple UI fixes #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kk7ds
commented
Jul 10, 2023
kk7ds
commented
- Fetch user information when loading modules
- Show memory fetch errors in row header tooltip
- Allow editing/fixing failed-to-load memories
- Fix disabling OK button in dialog while querying
This makes us look up the user information of a module that is selected in the module loader. If that user does not have the developer role on the project, warn the user before loading.
Related to #10705
When we fail to load a memory we show the row label in red to indicate this fact but do not allow an edit (or other edit operations that may include these) because we don't have a cached memory object. This patch makes us store an empty memory there so that an edit can proceed, likely to resolve the issue by starting fresh. Fixes #10705
kk7ds
force-pushed
the
more-ui
branch
2 times, most recently
from
a60a7e3
to
8a4163a
Compare
The CA RadioReference button was hijacking wx.ID_OK, preventing us from finding and disabling the right button while a query was going on. This fixes that by assigning it an ID of its own. Also disable the OK button during CA login for clarity. Fixes: #10704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.