Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tdh8 add only CH mode #719

Merged
merged 1 commit into from
Jul 12, 2023
Merged

tdh8 add only CH mode #719

merged 1 commit into from
Jul 12, 2023

Conversation

Sandmann34
Copy link
Contributor

TDH8 add a new function: only CH mode

@kk7ds
Copy link
Owner

kk7ds commented Jul 11, 2023

This looks fine, except for two things:

First, you should not need to change the images in the tree for this, and it's better if you don't to make sure you're not depending on something in them to make the tests work. Can you reset them so only the code is changed?

Second, your commit is authored by "unknown". Can you please set your identity and amend the commit?

git config --global user.name "John Doe"
git config --global user.email johndoe@example.com
git commit --amend --reset-author

Thanks. If you need help with the first one, I can fix it for you, but do the second thing for sure.

@kk7ds
Copy link
Owner

kk7ds commented Jul 11, 2023

After you amend, you will need to push with -f to force the update into this PR.

@kk7ds
Copy link
Owner

kk7ds commented Jul 11, 2023

Ah, this is why I wanted you to not change the images. It looks like your get_settings() and set_settings() are not identical so that the language isn't getting changed perhaps?

@kk7ds
Copy link
Owner

kk7ds commented Jul 11, 2023

I think this is what you want. Can you confirm this works on the actual radio for both English and Chinese? If so, we can merge this.

@Sandmann34
Copy link
Contributor Author

我想这就是你想要的。您能确认这在英语和中文的实际广播中都有效吗?如果是这样,我们可以合并它。

yes i tested it works.

@kk7ds
Copy link
Owner

kk7ds commented Jul 12, 2023

Cool, thanks.

@kk7ds kk7ds merged commit 705d000 into kk7ds:master Jul 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants