Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Retevis-RB627B [Enabled Power Mode and Set Max Power to 2W (2.00)] #721

Closed
wants to merge 1 commit into from
Closed

FIX: Retevis-RB627B [Enabled Power Mode and Set Max Power to 2W (2.00)] #721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions chirp/drivers/bf_t8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,12 +902,14 @@ class RetevisRB27V(RetevisRB27B):
class RetevisRB627B(RetevisRB27B):
VENDOR = "Retevis"
MODEL = "RB627B"
POWER_LEVELS = [chirp_common.PowerLevel("High", watts=0.50),
DUPLEXES = ['', '-', '+', 'off']
POWER_LEVELS = [chirp_common.PowerLevel("High", watts=2.00),
chirp_common.PowerLevel("Low", watts=0.50)]
ODD_SPLIT = False

_upper = 16
_pmr = True
_frs = _gmrs = _murs = False
_pmr = True
_frs = _murs = _pmr = False
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KC9HI Does this look right to you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It look like they are trying to remove the PMR restrictions from the RB627B like I have been doing for other Retevis models (I got the green light from them to drop PMR, FRS, GMRS, etc restrictions allow CHIRP to fully support the radios actual capability so I have been doing it when requested).

What I simply would have done here to drop the restrictions with the least amount of change would have been to simply change line 909 _pmr = True to _pmr = False and left line 910 alone. Removing _gmrs from line 910 could inadvertently turn on GMRS restrictions on for this PMR radio.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also been putting a comment on line 909 explaining:
_pmr = False # sold as PMR radio but supports full band TX/RX

Copy link
Contributor

@KC9HI KC9HI Jul 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I just remembered that the reason I didn't change this one is because the user can just use the RB27 selection and get the whole shooting match (99 channels, full band, wide/narrow bandwidth, high/low power, etc). There was no need to change RB27V or RB627B.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok...I understand ;) no problem, Good joob



@directory.register
Expand Down
Loading