Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv5r: Warn about other settings not being honored #724

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

kk7ds
Copy link
Owner

@kk7ds kk7ds commented Jul 13, 2023

No description provided.

@kk7ds kk7ds changed the title bug/10721/hn5rv uv5r: Warn about other settings not being honored Jul 13, 2023
@kk7ds
Copy link
Owner Author

kk7ds commented Jul 13, 2023

@KC9HI Let me know what you think. We can also just drop this and proceed with your proposed fix if you think it'd be better.

@KC9HI
Copy link
Contributor

KC9HI commented Jul 14, 2023

OK. I have done some testing. So this triggers a prompt when each affected setting is edited. Not what I was expecting but I see how this could be a useful thing to add to the Range Override Parameter setting on the Advanced Settings tab.

This needs to also be implemented for the settings listed under the Service Settings tab since they to are blocked from being uploaded.

@kk7ds
Copy link
Owner Author

kk7ds commented Jul 14, 2023

Ah I see I missed that change for the service ones. I'll add those.

And yes, it warns you for every single one - hopefully it'll be quite clear. It also only does it if your image has that version, so not everyone will get warned.

Users are being confused by the fact that HN5RV radios no longer have
the bulk of the "Other Settings" knobs. So, instead of hiding them
and generating bug reports, show them but warn the user that they
will not be uploaded to the radio and point them at the bug for
tracking the actual issue.

Related to #10721
Related to #10505
@KC9HI
Copy link
Contributor

KC9HI commented Jul 14, 2023

Correct. So if you make that change and merge it, I can make my change and fewer radios will get the warning. Hopefully the 2 things together will eliminated (or at least reduce) the daily tickets regarding the missing tabs. :)

@KC9HI
Copy link
Contributor

KC9HI commented Jul 14, 2023

OK. Looks good to me. I think I understand what you did good enough to be able to integrate what I've done with what you've done.

@kk7ds
Copy link
Owner Author

kk7ds commented Jul 14, 2023

Cool, sounds great, thanks!

@kk7ds kk7ds merged commit 249a7a3 into master Jul 14, 2023
6 checks passed
@kk7ds kk7ds deleted the bug/10721/hn5rv branch July 14, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants