Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full band rb15 rb615 #755

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Full band rb15 rb615 #755

merged 3 commits into from
Aug 16, 2023

Conversation

KC9HI
Copy link
Contributor

@KC9HI KC9HI commented Aug 15, 2023

CHIRP PR Checklist

The following must be true before PRs can be merged:

  • All tests must be passing.
  • Commits should be squashed into logical units.
  • Commits should be rebased (or simply rebase-able in the web UI) on current master. Do not put merge commits in a PR.
  • Commits in a single PR should be related.
  • Major new features or bug fixes should reference a CHIRP issue.
  • New drivers should be accompanied by a test image in tests/images (except for thin aliases where the driver is sufficiently tested already).
  • All files must be GPLv3 licensed or contain no license verbiage. No additional restrictions can be placed on the usage (i.e. such as noncommercial).

Please also follow these guidelines:

  • Keep cleanups in separate commits from functional changes.
  • Please write a reasonable commit message, especially if making some change that isn't totally obvious (such as adding a new model, adding a feature, etc).
  • Do not add new py2-compatibility code (No new uses of six, future, etc).
  • All new drivers should set NEEDS_COMPAT_SERIAL=False and use MemoryMapBytes.
  • New drivers and radio models will affect the Python3 test matrix. You should regenerate this file with tox -emakesupported and include it in your commit.

@kk7ds
Copy link
Owner

kk7ds commented Aug 15, 2023

It looks like there is other stuff in the works for this driver. Should we hold off a day and merge it all together? Or is it likely to take longer?

@KC9HI
Copy link
Contributor Author

KC9HI commented Aug 15, 2023

I don't think it will hurt to wait. I'm not sure I will be able to pull off a fix on my own but I want to give it a try, first.

No tone is 0xC000 instead of 0x0000
@KC9HI
Copy link
Contributor Author

KC9HI commented Aug 16, 2023

The fix turned out to be easy. I just had to walk away from it for a little bit.

@kk7ds kk7ds merged commit fa43f8f into kk7ds:master Aug 16, 2023
6 checks passed
@KC9HI KC9HI deleted the full-band-rb15-rb615 branch August 29, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants