Fixes PR #6067

[k9ps-paul]

CHIRP PR Checklist

The following must be true before PRs can be merged:

• All tests must be passing.
• Commits should be squashed into logical units.
• Commits should be rebased (or simply rebase-able in the web UI) on current master. Do not put merge commits in a PR.
• Commits in a single PR should be related.
• Major new features or bug fixes should reference a CHIRP issue.
• New drivers should be accompanied by a test image in tests/images (except for thin aliases where the driver is sufficiently tested already).
• All files must be GPLv3 licensed or contain no license verbiage. No additional restrictions can be placed on the usage (i.e. such as noncommercial).

Please also follow these guidelines:

• Keep cleanups in separate commits from functional changes.
• Please write a reasonable commit message, especially if making some change that isn't totally obvious (such as adding a new model, adding a feature, etc).
• Do not add new py2-compatibility code (No new uses of six, future, etc).
• All new drivers should set NEEDS_COMPAT_SERIAL=False and use MemoryMapBytes.
• New drivers and radio models will affect the Python3 test matrix. You should regenerate this file with tox -emakesupported and include it in your commit.

[kk7ds]

Hi Paul, this looks mostly fine, thanks. In the future, I'd ask for a more descriptive commit message. The first line of that goes out in the announce emails and "Fixes PR #6067" won't mean anything to people on chirp-users, and of course, won't be very helpful in the future when looking at the commit history.

I'll fix that up for you this time so you don't have to worry about the amend and re-push.

Thanks!

[k9ps-paul]

Understood. Thanks for the feedack. 73, Paul / K9PS

…

On Sun, 2023-09-10 at 15:10 -0700, Dan Smith wrote: Hi Paul, this looks mostly fine, thanks. In the future, I'd ask for a more descriptive commit message. The first line of that goes out in the announce emails and "Fixes PR #6067" won't mean anything to people on chirp-users, and of course, won't be very helpful in the future when looking at the commit history. I'll fix that up for you this time so you don't have to worry about the amend and re-push. Thanks! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.