Misc fixes #777
Merged
Misc fixes #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kk7ds
commented
Sep 28, 2023
kk7ds
commented
- Log query parameters for network sources
- Fix revealing locations like debug log
This makes it easier to help debug failures from just a log.
A change to enable revealing the stock configs directory a while back broke revealing the debug log location as well. This fixes that by stripping down to the containing directory for windows only. Also, this fixes the race between generating the debug log copy, accessing it, and then removing it as a temporary file. Found while investigating #10869
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.