Added back to check that there is data when building inversion matrices #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason 'if ds.coords['lat'].size > 1: #If there is data inside biggrid ' was removed on line 289.
If it turns out that the dataset added has no data inside the biggrid region, the subsequent building of GTG and GTd will fail. Not sure why this was removed. I can not see anything elsewhere in the code that should prevent it from chrashing, which was why i came across this.
Changed also from the deprecated pd.append to pd.concat in dataloader.py. This was pointed out by @billetd in #31 . This fix should close that issue.