-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you haven't modified any code in FeeDel & PartialFeeDel examples, then remove those files from this PR for clarity.
web3js-ext/src/web3/klaytn_tx.ts
Outdated
// @ts-ignore | ||
this.key = txData.key; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define 'key' in KlaytnTxData type at L10, then remove ts-ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I did a450199
web3js-ext/src/web3/klaytn_tx.ts
Outdated
|
||
// A readonly CoreKlaytnTx object | ||
this.klaytnTxData = KlaytnTxFactory.fromObject({ | ||
let initTxData = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name it klaytnTxObject
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 854b25b
web3js-ext/src/web3/klaytn_tx.ts
Outdated
key: this.key, | ||
}; | ||
|
||
if ( txData.type == 0x28 ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the TxType enum please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, I checked 076027b
(The Partial FeeDelegation part was completed more easily than I expected, so it was added.)