This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Feat: update klay sdks #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sotatek-TanHoang
requested review from
kjeom,
nohkwak,
JayChoi1736 and
blukat29
as code owners
blukat29
reviewed
Jun 4, 2024
web3rpc/rpc-specs/paths/klay/miscellaneous/getAllRecordsFromRegistry.yaml
Show resolved
Hide resolved
web3rpc/rpc-specs/paths/klay/miscellaneous/getActiveAddressFromRegistry.yaml
Show resolved
Hide resolved
Sotatek-TanHoang
commented
Jun 6, 2024
| @@ -15,7 +15,7 @@ repositories { | |||
| } | |||
|
|
|||
| dependencies { | |||
| api "foundation.klaytn:web3rpc-java:v0.9.0" | |||
| api "foundation.klaytn:web3rpc-java:v1.0.1" | |||
| implementation "org.web3j:core:4.9.7" | |||
There was a problem hiding this comment.
The generated sdk have version 1.0.1 so i need to change build.gradle version of web3rpc-java to match the local build
kjeom
reviewed
Jun 10, 2024
| params: | ||
| type: array | ||
| items: | ||
| anyOf: |
There was a problem hiding this comment.
@Sotatek-TanHoang As I said, you should avoid anyOf type
| params: | ||
| type: array | ||
| items: | ||
| anyOf: |
There was a problem hiding this comment.
Same comments. Please look at above
Sotatek-TanHoang
force-pushed
the
feat/update-klay-sdk
branch
from
6e414a6
to
f45a1cc
Compare
kjeom
approved these changes
Jun 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- klay_getBlsInfor
- klay_getActiveAddressFromRegistry
- klay_getAllRecordsFromRegistry
- klay_getTotalSupply
- klay_gasPrice
- eth_gasPrice
- klay_maxPriorityFeePerGas
- eth_maxPriorityFeePerGas
- klay_feeHistory
- eth_feeHistory