Fix CI: Regenerate docs for authz subcommands #1231
Conversation
Signed-off-by: Ravjot Singh <ravu2004@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| kmeshctl authz <kmesh-daemon-pod> enable/disable | ||
|
|
||
| # If you want to enable or disable authz offloading of all Kmeshs in the cluster | ||
| kmeshctl authz enable/disable |
There was a problem hiding this comment.
Sorry, this document is autogenerated by the make gen tool based on CLI command comments. Therefore, your changes will not pass the checks in the GitHub Action.
There was a problem hiding this comment.
I had run make gen command in my local these changes are made by that action. I thought that it would resolve ci issues...
There was a problem hiding this comment.
Do you mean you submitted this PR after running make gen commands?
There was a problem hiding this comment.
Yaa kinda like that
There was a problem hiding this comment.
This is what I get when I run make gen-check:
Please confirm that the changes to the c-file in PR were caused by make gen-check?
There was a problem hiding this comment.
make gen-check only is a tool.
You can revert your changes, then run make gen. After that, submit your changes again.
There was a problem hiding this comment.
Sure I will update this pr, actually I missed this flow initially
There was a problem hiding this comment.
When will this PR be updated?
There was a problem hiding this comment.
This PR issue is blocking the #1237
There was a problem hiding this comment.
When will this PR be updated?
i am working on this
| @@ -244,7 +244,7 @@ static inline int convert_v6(char *data, __u32 *ip6) | |||
| __u16 ip_1 = (ip >> 0) & 0xFFFF; | |||
| __u16 ip_2 = (ip >> 16) & 0xFFFF; | |||
| for (int j = 0; j < 2; j++) { | |||
| __u16 ip_1 = (ip)&0xFFFF; | |||
| __u16 ip_1 = (ip) & 0xFFFF; | |||
There was a problem hiding this comment.
Why change & related format?
There was a problem hiding this comment.
It's autogenrated by make gen command
|
gen check failed |
Hey, can u guide me in right direction why these checks are failing |
|
related to, the CI use clang format. I think you can revert these white spaces added around |
ok @hzxuzhonghu i will try this once |
|
please update |
|
This has been modified #1241 |
Fix ci issues in #1217