Skip to content

Update preferred resoures in registry #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tamalsaha merged 1 commit into from
Feb 20, 2026
Merged

Update preferred resoures in registry #594

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion hub/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,13 @@ func (r *Registry) RegisterGVR(gvr schema.GroupVersionResource) error {
r.regGVK[rd.Spec.Resource.GroupVersionKind()] = &rd.Spec.Resource
r.regGVR[rd.Spec.Resource.GroupVersionResource()] = &rd.Spec.Resource
r.cache.Set(filename, rd)

if existing, ok := r.preferred[gvr.GroupResource()]; !ok {
r.preferred[gvr.GroupResource()] = gvr
} else if diff, _ := apiversion.Compare(existing.Version, gvr.Version); diff < 0 {
r.preferred[gvr.GroupResource()] = gvr
}

return nil
}

Expand Down Expand Up @@ -275,7 +282,11 @@ func (r *Registry) createRegistry(cfg *rest.Config) (map[schema.GroupResource]sc
preferred := make(map[schema.GroupResource]schema.GroupVersionResource)
for _, rd := range reg {
gvr := rd.Spec.Resource.GroupVersionResource()
preferred[gvr.GroupResource()] = gvr
if existing, ok := preferred[gvr.GroupResource()]; !ok {
preferred[gvr.GroupResource()] = gvr
} else if diff, _ := apiversion.Compare(existing.Version, gvr.Version); diff < 0 {
preferred[gvr.GroupResource()] = gvr
}
}

err = fs.WalkDir(resourcedescriptors.EmbeddedFS(), ".", func(filename string, e fs.DirEntry, err error) error {
Expand Down
Loading