Add parameterstore provider #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @tchssk. I'm not familiar with parameterstore and the version you linked, but your implementation looks good in general. Good to merge? |
|
Yes, please! |
|
Done. Released with the tag |
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector
Feb 6, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/knadh/koanf/v2](https://togithub.com/knadh/koanf) | `v2.0.1` -> `v2.0.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>knadh/koanf (github.com/knadh/koanf/v2)</summary> ### [`v2.0.2`](https://togithub.com/knadh/koanf/releases/tag/v2.0.2) [Compare Source](https://togithub.com/knadh/koanf/compare/v2.0.1...v2.0.2) #### What's Changed - feat: add nats provider by [@​TECHNOFAB11](https://togithub.com/TECHNOFAB11) in [https://github.com/knadh/koanf/pull/213](https://togithub.com/knadh/koanf/pull/213) - feat: add flag to optionally fetch secret metadata by [@​Thunderbottom](https://togithub.com/Thunderbottom) in [https://github.com/knadh/koanf/pull/219](https://togithub.com/knadh/koanf/pull/219) - chore: change WithMeta to ExcludeMeta for backwards compatibility by [@​Thunderbottom](https://togithub.com/Thunderbottom) in [https://github.com/knadh/koanf/pull/220](https://togithub.com/knadh/koanf/pull/220) - typos and little clearer code by [@​GreyXor](https://togithub.com/GreyXor) in [https://github.com/knadh/koanf/pull/222](https://togithub.com/knadh/koanf/pull/222) - Fixed a nil panic issue in vault provider by [@​wangkang](https://togithub.com/wangkang) in [https://github.com/knadh/koanf/pull/224](https://togithub.com/knadh/koanf/pull/224) - Not use deprecated io/ioutil by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/knadh/koanf/pull/226](https://togithub.com/knadh/koanf/pull/226) - Proposal: support Vault auth method by [@​missedone](https://togithub.com/missedone) in [https://github.com/knadh/koanf/pull/229](https://togithub.com/knadh/koanf/pull/229) - Add parameterstore provider by [@​tchssk](https://togithub.com/tchssk) in [https://github.com/knadh/koanf/pull/227](https://togithub.com/knadh/koanf/pull/227) - feat: optional support net/http transport by [@​missedone](https://togithub.com/missedone) in [https://github.com/knadh/koanf/pull/232](https://togithub.com/knadh/koanf/pull/232) - breaking change: [#​233](https://togithub.com/knadh/koanf/issues/233) return error struct to avoid panic at runtime by [@​missedone](https://togithub.com/missedone) in [https://github.com/knadh/koanf/pull/234](https://togithub.com/knadh/koanf/pull/234) - Bump github.com/nats-io/nkeys from 0.4.4 to 0.4.6 in /providers/nats by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/knadh/koanf/pull/246](https://togithub.com/knadh/koanf/pull/246) - Bump golang.org/x/net from 0.7.0 to 0.17.0 in /providers/etcd by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/knadh/koanf/pull/248](https://togithub.com/knadh/koanf/pull/248) - Bump golang.org/x/net from 0.7.0 to 0.17.0 in /providers/vault by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/knadh/koanf/pull/247](https://togithub.com/knadh/koanf/pull/247) - Bump github.com/nats-io/nats-server/v2 from 2.9.15 to 2.9.23 in /providers/nats by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/knadh/koanf/pull/241](https://togithub.com/knadh/koanf/pull/241) - Bump google.golang.org/grpc from 1.53.0 to 1.56.3 in /providers/etcd by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/knadh/koanf/pull/243](https://togithub.com/knadh/koanf/pull/243) - fix: typo by [@​testwill](https://togithub.com/testwill) in [https://github.com/knadh/koanf/pull/251](https://togithub.com/knadh/koanf/pull/251) - Bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /providers/vault by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/knadh/koanf/pull/261](https://togithub.com/knadh/koanf/pull/261) - Bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /providers/nats by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/knadh/koanf/pull/260](https://togithub.com/knadh/koanf/pull/260) - Add optional `Opt{}` param that takes a koanf instance to match posflag's default value behaviour in basic flag. Closes [#​255](https://togithub.com/knadh/koanf/issues/255). by [@​knadh](https://togithub.com/knadh) in [https://github.com/knadh/koanf/pull/259](https://togithub.com/knadh/koanf/pull/259) - Parser: KDL by [@​dezren39](https://togithub.com/dezren39) in [https://github.com/knadh/koanf/pull/266](https://togithub.com/knadh/koanf/pull/266) - Parser: KDL kdl-go dependency update by [@​dezren39](https://togithub.com/dezren39) in [https://github.com/knadh/koanf/pull/267](https://togithub.com/knadh/koanf/pull/267) #### New Contributors - [@​TECHNOFAB11](https://togithub.com/TECHNOFAB11) made their first contribution in [https://github.com/knadh/koanf/pull/213](https://togithub.com/knadh/koanf/pull/213) - [@​GreyXor](https://togithub.com/GreyXor) made their first contribution in [https://github.com/knadh/koanf/pull/222](https://togithub.com/knadh/koanf/pull/222) - [@​wangkang](https://togithub.com/wangkang) made their first contribution in [https://github.com/knadh/koanf/pull/224](https://togithub.com/knadh/koanf/pull/224) - [@​tchssk](https://togithub.com/tchssk) made their first contribution in [https://github.com/knadh/koanf/pull/226](https://togithub.com/knadh/koanf/pull/226) - [@​missedone](https://togithub.com/missedone) made their first contribution in [https://github.com/knadh/koanf/pull/229](https://togithub.com/knadh/koanf/pull/229) - [@​testwill](https://togithub.com/testwill) made their first contribution in [https://github.com/knadh/koanf/pull/251](https://togithub.com/knadh/koanf/pull/251) - [@​dezren39](https://togithub.com/dezren39) made their first contribution in [https://github.com/knadh/koanf/pull/266](https://togithub.com/knadh/koanf/pull/266) **Full Changelog**: knadh/koanf@v2.0.1...v2.0.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defensestation version is easy to use for fetching one parameter, but it's nice to have a provider with as many configurable options as possible.
Please let me know your opinion.
Supported parameter types
There are three types of parameters in Parameter Store.
The defensestation version supports String and StringList, but does not support decrypting SecureString. This provider accepts the API Input itself, so all options are configurable, including decryption.
Supported API methods
There are three API methods to get parameters from Parameter Store.
The defensestation version only uses GetParameter, so it is not possible to fetch multiple parameters. This provider uses one of three all methods depending on the input.