Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomad provider #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nomad provider #297

wants to merge 1 commit into from

Conversation

mkvolkov
Copy link
Contributor

Added Nomad provider (remade).

Options:

  • allocations (basic data / networks)
  • raft configuration
  • variables

@knadh
Copy link
Owner

knadh commented Jul 1, 2024

Thanks for the PR. Could you please check the broken tests?

@mkvolkov
Copy link
Contributor Author

mkvolkov commented Jul 1, 2024

My Go version is 1.22.3. Seems that Nomad api doesn't work with older versions

@rhnvrm
Copy link
Collaborator

rhnvrm commented Jul 1, 2024

Maybe, it might be possible to a build constraint. Eg.

//go:build go1.19
// +build go1.19

Also: https://github.com/knadh/koanf/blob/master/go.work

@knadh
Copy link
Owner

knadh commented Jul 17, 2024

@rhnvrm will removing ./examples from go.work fix this and other similar issues in the future? Is there any need to keep the examples dir in the workspace?

@rhnvrm
Copy link
Collaborator

rhnvrm commented Jul 20, 2024

I think just adding the build constraint should suffice. Removing examples from workspace will not fix the broken tests, I am guessing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants