Skip to content

Comments

fix: add safety checks to prevent runtime crashes#63

Open
Tusharjamdade wants to merge 1 commit intoknative-extensions:mainfrom
Tusharjamdade:bugfix/funnel-sink-crash
Open

fix: add safety checks to prevent runtime crashes#63
Tusharjamdade wants to merge 1 commit intoknative-extensions:mainfrom
Tusharjamdade:bugfix/funnel-sink-crash

Conversation

@Tusharjamdade
Copy link

Changes

This PR adds defensive checks to prevent the application from crashing in multiple edge cases, including:

  • Connecting a funnel (event source) directly to a sink.
  • Attempting invalid connections after a valid Trigger → Sink path is already established.
  • Starting the simulation with incomplete or partially configured event paths.
  • Handling cases where conveyor and destination states become out of sync.
  • Preventing runtime errors caused by null references, deleted event nodes, or out-of-bounds access.

The gameplay and learning flow remain unchanged the system now handles invalid user interactions gracefully instead of crashing.

/kind

Fixes #62

Release Note
Fixed a crash that could occur when users created invalid or incomplete event flow connections. The game now handles such interactions gracefully across all levels.


Docs


@knative-prow
Copy link

knative-prow bot commented Jan 28, 2026

@Tusharjamdade: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

This PR adds defensive checks to prevent the application from crashing in multiple edge cases, including:

  • Connecting a funnel (event source) directly to a sink.
  • Attempting invalid connections after a valid Trigger → Sink path is already established.
  • Starting the simulation with incomplete or partially configured event paths.
  • Handling cases where conveyor and destination states become out of sync.
  • Preventing runtime errors caused by null references, deleted event nodes, or out-of-bounds access.

The gameplay and learning flow remain unchanged the system now handles invalid user interactions gracefully instead of crashing.

/kind

Fixes #62

Release Note
Fixed a crash that could occur when users created invalid or incomplete event flow connections. The game now handles such interactions gracefully across all levels.


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from Leo6Leo and mmejia02 January 28, 2026 19:06
@knative-prow
Copy link

knative-prow bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tusharjamdade
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 28, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Tusharjamdade / name: Tushar Jamdade (ce504b5)

@knative-prow
Copy link

knative-prow bot commented Jan 28, 2026

Welcome @Tusharjamdade! It looks like this is your first PR to knative-extensions/educational-game 🎉

@knative-prow knative-prow bot added the size/M label Jan 28, 2026
Signed-off-by: Tusharjamdade <tusharnjamdade@gmail.com>
@Tusharjamdade Tusharjamdade force-pushed the bugfix/funnel-sink-crash branch from ed8fa40 to ce504b5 Compare January 28, 2026 19:08
@Tusharjamdade
Copy link
Author

Tusharjamdade commented Jan 29, 2026

Hi @Cali0707, @ankitajana21 and @prajjwalyd,

Could you please take a look and let me know if there are any required changes?
I would also recommend watching the videos linked in the issue description to understand how the system crashes.

Fix:

2026-01-28.22-46-32.mp4

This PR resolves one of the issues demonstrated in the video.

@knative-prow-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Application crashes when creating invalid or incomplete event connections

2 participants