Skip to content

Comments

feat: Add sink availability indicator with blinking light#66

Open
Tusharjamdade wants to merge 2 commits intoknative-extensions:mainfrom
Tusharjamdade:feature/availability-indicator
Open

feat: Add sink availability indicator with blinking light#66
Tusharjamdade wants to merge 2 commits intoknative-extensions:mainfrom
Tusharjamdade:feature/availability-indicator

Conversation

@Tusharjamdade
Copy link

Changes

  • 🎁 Added available export variable to Scripts/sink.gd to control sink status (defaults to true).
  • 🎁 Added a visual IndicatorLight (centered green circle) to Scenes/sink.tscn.
  • 🎁 Implemented a blinking animation in _process that activates only when the sink is available.
  • 🐛 Set mouse_filter = 2 (Ignore) on the indicator light so it does not block mouse clicks on the sink.

/kind

Fixes #65

Release Note

Added a blinking green indicator light to sinks to visually represent their availability status.

Docs


Signed-off-by: Tusharjamdade <tusharnjamdade@gmail.com>
Signed-off-by: Tusharjamdade <tusharnjamdade@gmail.com>
@knative-prow
Copy link

knative-prow bot commented Jan 29, 2026

@Tusharjamdade: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

  • 🎁 Added available export variable to Scripts/sink.gd to control sink status (defaults to true).
  • 🎁 Added a visual IndicatorLight (centered green circle) to Scenes/sink.tscn.
  • 🎁 Implemented a blinking animation in _process that activates only when the sink is available.
  • 🐛 Set mouse_filter = 2 (Ignore) on the indicator light so it does not block mouse clicks on the sink.

/kind

Fixes #65

Release Note

Added a blinking green indicator light to sinks to visually represent their availability status.

Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow
Copy link

knative-prow bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tusharjamdade
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from Cali0707 and mmejia02 January 29, 2026 18:52
@knative-prow knative-prow bot added the size/M label Jan 29, 2026
@Tusharjamdade
Copy link
Author

Hi @Cali0707 and @ankitajana21,

I’ve added a green indicator to show the availability of the sink, as demonstrated in the video below. This functionality works consistently across all levels.

Please take a look and let me know if any changes are needed.

2026-01-30.00-23-26.mp4

@iwdie
Copy link
Contributor

iwdie commented Jan 30, 2026

Hi @Tusharjamdade ,
Thanks for working on this!!
I think it works fine overall, but I have a small suggestion. The light becomes invisible when an event gets in the sink . The simplest fix might be to shift it to the right side. You could also adjust the Z-index, but I wouldn’t recommend that.
I also don’t think using a Panel node for the light was the best approach. Using a ColorRect would have been a better option, since UI nodes sometimes cause issues, and you wouldn’t have needed to set mouse_filter to Ignore. It still works fine though!

@Tusharjamdade
Copy link
Author

Hi @iwdie,

I previously tested adding the indicator on the right side, but it didn’t make much sense visually, so I moved it to the center.

Also, added mouse_filter so that mouse clicks pass through the indicator to the component below it (the sink), which might be helpful in case of misclicks on the indicator, since it is placed at the center.

@knative-prow-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sink availability indicator

3 participants