Skip to content

Commit

Permalink
Use kubernetes.io/metadata.name for namespace selector (#2993)
Browse files Browse the repository at this point in the history
Instead of using the custom `app.kubernetes.io/name` for
selecting a specific namespace we use the
`kubernetes.io/metadata.name` label that is enforced by the
API server on each namespace
https://kubernetes.io/docs/reference/labels-annotations-taints/#kubernetes-io-metadata-name

The benefit is that some installations create the system
namespace themself so the app.kubernetes.io/name that
is defined in core might not be present, leading to
a non functioning KafkaSource.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
  • Loading branch information
knative-prow-robot and pierDipi committed Mar 2, 2023
1 parent caceb4b commit 6a9c444
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ webhooks:
matchPolicy: Equivalent
namespaceSelector:
matchLabels:
app.kubernetes.io/name: knative-eventing
kubernetes.io/metadata.name: knative-eventing
objectSelector:
matchLabels:
app.kubernetes.io/component: kafka-dispatcher

0 comments on commit 6a9c444

Please sign in to comment.