Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.15] Allow enabling sarama logging and disabling client pool (#4103) #4108

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[release-1.15] Allow enabling sarama logging and disabling client pool (#4103) #4108

merged 1 commit into from
Sep 20, 2024

Conversation

pierDipi
Copy link
Member

Backport of #4103

@pierDipi
Allow enabling sarama logging and disabling client pool (knative-exte…
b6cca2a 
…nsions#4103)

Add 3 new environment variables:
```
ENABLE_SARAMA_LOGGER       (default: false)
ENABLE_SARAMA_DEBUG_LOGGER (default: false)
ENABLE_SARAMA_CLIENT_POOL  (default: true)
```

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.89189% with 43 lines in your changes missing coverage. Please review.

Project coverage is 48.10%. Comparing base (a7715ef) to head (b6cca2a).
Report is 2 commits behind head on release-1.15.

Files with missing lines Patch % Lines
control-plane/pkg/kafka/clientpool/clientpool.go 21.42% 11 Missing ⚠️
control-plane/cmd/kafka-controller/main.go 0.00% 6 Missing ⚠️
...ane/pkg/reconciler/broker/namespaced_controller.go 0.00% 5 Missing ⚠️
...l-plane/pkg/reconciler/consumergroup/controller.go 42.85% 2 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/trigger/controller.go 42.85% 2 Missing and 2 partials ⚠️
...ne/pkg/reconciler/trigger/namespaced_controller.go 42.85% 2 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/broker/controller.go 66.66% 1 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/channel/controller.go 75.00% 1 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/sink/controller.go 57.14% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@               Coverage Diff                @@
##           release-1.15    #4108      +/-   ##
================================================
- Coverage         48.22%   48.10%   -0.12%     
================================================
  Files               246      246              
  Lines             14597    14640      +43     
================================================
+ Hits               7039     7043       +4     
- Misses             6848     6875      +27     
- Partials            710      722      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

creydr
creydr approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/test reconciler-tests

@pierDipi
Copy link
Member Author

/retest-required

@creydr
Copy link
Contributor

creydr commented Sep 20, 2024

/test upgrade-tests

@knative-prow knative-prow bot merged commit f62e51f into knative-extensions:release-1.15 Sep 20, 2024
36 of 37 checks passed
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request Sep 24, 2024
@pierDipi
Allow enabling sarama logging and disabling client pool (knative-exte…
f5f7abf 
…nsions#4103) (knative-extensions#4108)

Add 3 new environment variables:
```
ENABLE_SARAMA_LOGGER       (default: false)
ENABLE_SARAMA_DEBUG_LOGGER (default: false)
ENABLE_SARAMA_CLIENT_POOL  (default: true)
```

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@matzew matzew Awaiting requested review from matzew

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierDipi @creydr