Discard invalid consumer records #4128
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
|
/cherry-pick release-1.15 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.14 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4128 +/- ##
=======================================
Coverage 48.51% 48.51%
=======================================
Files 244 244
Lines 14928 14928
=======================================
Hits 7242 7242
Misses 6955 6955
Partials 731 731 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
discard-invalid-records
branch
from
d253c64
to
69b9873
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow
bot
added
size/M
|
/retest-required |
|
/retest-required |
3 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/test reconciler-tests-namespaced-broker |
|
/retest-required |
|
/retest |
|
Can we expedite this. This is breaking entire clusters. |
|
/test reconciler-tests-namespaced-broker |
1 similar comment
|
/test reconciler-tests-namespaced-broker |
|
/retest |
|
/retest-required |
|
/retest |
|
@pierDipi: new pull request created: #4140 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pierDipi: new pull request created: #4141 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Invalid records shouldn't block consuming events.
The record will eventually end up here and discarded:
https://github.com/knative-extensions/eventing-kafka-broker/blob/main/data-plane/dispatcher/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/impl/RecordDispatcherImpl.java#L168-L177
Fixes #4129
Proposed Changes