Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest dependencies #4149

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Upgrade to latest dependencies #4149

wants to merge 2 commits into from

Conversation

pierDipi
Copy link
Member

Fix for #4147

knative-automation and others added 2 commits October 30, 2024 01:52
@knative-automation
upgrade to latest dependencies
dd0aaa8 
bumping knative.dev/eventing ef6b31a...7c97e6f:
  > 7c97e6f Schduler: MAXFILLUP strategy will spread vreplicas across multiple pods (# 8263)

Signed-off-by: Knative Automation <automation@knative.team>
@pierDipi
Fix consumer group build error and remove unused configs
036d8d8 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 31, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@bdf6a8b). Learn more about missing BASE report.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4149   +/-   ##
=======================================
  Coverage        ?   45.50%           
=======================================
  Files           ?      270           
  Lines           ?    19873           
  Branches        ?        0           
=======================================
  Hits            ?     9044           
  Misses          ?    10111           
  Partials        ?      718

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

creydr
creydr reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2024
@pierDipi
Copy link
Member Author

/retest

3 similar comments
@pierDipi
Copy link
Member Author

pierDipi commented Nov 4, 2024

/retest

@pierDipi
Copy link
Member Author

pierDipi commented Nov 5, 2024

/retest

@pierDipi
Copy link
Member Author

pierDipi commented Nov 7, 2024

/retest

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 7, 2024

@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing-kafka-broker_main 036d8d8 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr left review comments

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @creydr @knative-automation