💝 Migrating to sink flag for --to param #1610
Triggered via pull request
September 23, 2024 17:25
cardil
Status
Failure
Total duration
2m 13s
Artifacts
–
knative-style.yaml
on: pull_request
style
/
changes
3s
style
/
...
/
Auto-format and Check
11s
style
/
...
/
Lint
1m 48s
style
/
...
/
Do Not Submit
3s
style
/
...
/
shell
0s
style
/
...
/
yaml
18s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
12 errors and 5 warnings
|
style / Golang / Auto-format and Check:
pkg/system/environment.go#L1
Please run goimports.
diff --git a/pkg/system/environment.go b/pkg/system/environment.go
index 519b511..9b140a3 100644
--- a/pkg/system/environment.go
+++ b/pkg/system/environment.go
@@ -1,2 +1 @@
package system
-
|
|
style / Golang / Auto-format and Check
Process completed with exit code 1.
|
|
style / Golang / Lint:
pkg/k8s/test/addressresolver_cases.go#L29
don't use `init` function (gochecknoinits)
|
|
style / Golang / Lint:
pkg/tests/fakeclients.go#L43
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
style / Golang / Lint:
pkg/k8s/kubeclient.go#L29
Comment should end in a period (godot)
|
|
style / Golang / Lint:
pkg/k8s/addressresolver.go#L41
var-naming: method parameter relativeUri should be relativeURI (revive)
|
|
style / Golang / Lint:
pkg/k8s/addressresolver.go#L60
var-naming: func parameter relativeUri should be relativeURI (revive)
|
|
style / Golang / Lint:
pkg/event/target.go#L24
var-naming: struct field RelativeUri should be RelativeURI (revive)
|
|
style / Golang / Lint:
pkg/cli/target.go#L79
var-naming: func isValidAbsUrl should be isValidAbsURL (revive)
|
|
style / Golang / Lint:
pkg/cli/target.go#L65
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
|
style / Golang / Lint:
pkg/cli/context_test.go#L27
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
style / Golang / Lint:
pkg/sender/in_cluster_test.go#L99
unused-parameter: parameter 'ref' seems to be unused, consider removing or renaming it as _ (revive)
|
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/kn-plugin-event/kn-plugin-event. Supported file pattern: go.sum
|
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/kn-plugin-event/kn-plugin-event. Supported file pattern: go.sum
|
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/kn-plugin-event/kn-plugin-event. Supported file pattern: go.sum
|
|
style / suggester / yaml
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/kn-plugin-event/kn-plugin-event. Supported file pattern: go.sum
|