🗑️ Migrate to wavesoftware/commandline package

[cardil]

Changes

• 🗑️ Migrate to wavesoftware/commandline package

/kind cleanup

Fixes #181

[codecov]

Codecov Report

Merging #205 (9a92207) into main (2652e4f) will increase coverage by 0.46%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   67.50%   67.97%   +0.46%     
==========================================
  Files          36       35       -1     
  Lines        1151     1121      -30     
==========================================
- Hits          777      762      -15     
+ Misses        313      299      -14     
+ Partials       61       60       -1     

Impacted Files	Coverage Δ
pkg/cli/target.go	48.57% <25.00%> (ø)
internal/ics/app.go	90.00% <90.00%> (ø)
cmd/kn-event-sender/main.go	100.00% <100.00%> (+30.76%)	⬆️
cmd/kn-event/main.go	100.00% <100.00%> (ø)
internal/cli/cmd/build.go	56.00% <100.00%> (-3.26%)	⬇️
internal/cli/cmd/root.go	100.00% <100.00%> (+17.94%)	⬆️
internal/cli/cmd/send.go	77.41% <100.00%> (ø)
internal/cli/cmd/version.go	78.78% <100.00%> (ø)
pkg/cli/create.go	80.86% <100.00%> (ø)
pkg/cli/ics/send.go	55.00% <100.00%> (+2.36%)	⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[cardil]

/test integration-tests_kn-plugin-event_main

Flake?

[cardil]

/assign @dsimansk
/assign @rhuss
/cc @vyasgun

[dsimansk]

IMO looks good, I wonder if that common code could live in knative/client-pkg maybe. We'd like to revive that from the dusts. Otherwise it looks good, feel free to unhold.

/approve
/lgtm
/hold

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cardil,dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cardil]

I wonder if that common code could live in knative/client-pkg maybe

I'm using that commandline package in knative/test-infra tools now. See knative/test-infra#3513 and knative/test-infra#2995. I think it's not a good idea to import knative/client-pkg from knative/test-infra.

[cardil]

/unhold

[cardil]

I'm also using that commandline package in knative/hack#222