Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎁 Using embedded knative.dev/hack scripts #220

Closed
wants to merge 2 commits into from
Closed

🎁 Using embedded knative.dev/hack scripts #220

wants to merge 2 commits into from

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Sep 9, 2022

Changes

  • 🎁 Using embedded knative.dev/hack scripts

/kind enhancement

Fixes #TBD

@knative-prow
Copy link

knative-prow bot commented Sep 9, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added kind/enhancement do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 9, 2022
@knative-prow
Copy link

knative-prow bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
@cardil
Copy link
Contributor Author

cardil commented Sep 9, 2022

/test all

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022 •
edited
Loading

Codecov Report

Merging #220 (065f3c2) into main (dc74d72) will increase coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 065f3c2 differs from pull request most recent head 1738a46. Consider uploading reports for the commit 1738a46 to get more accurate results

@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   67.97%   68.17%   +0.19%     
==========================================
  Files          35       35              
  Lines        1121     1128       +7     
==========================================
+ Hits          762      769       +7     
  Misses        299      299              
  Partials       60       60
Impacted Files Coverage Δ
internal/cli/cmd/root.go 100.00% <0.00%> (ø)
pkg/sender/in_cluster.go 86.95% <0.00%> (+0.91%) ⬆️
pkg/k8s/jobrunner.go 69.00% <0.00%> (+0.95%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cardil cardil mentioned this pull request Sep 9, 2022
Merged
cardil
cardil commented Sep 9, 2022
View reviewed changes
go.mod Outdated
@@ -32,6 +32,9 @@ require (
sigs.k8s.io/yaml v1.3.0
)

// FIXME: remove this once https://github.com/knative/hack/pull/222 is merged
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Remove this once knative/hack#222 is merged

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2022
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 21, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2022
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 3, 2022
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2022
@knative-prow-robot
Copy link

@cardil: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 2, 2023
@github-actions github-actions bot closed this Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cardil @knative-prow-robot