Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.15] 🐛 Use patch level version in go.mod files #385

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Nov 5, 2024

Changes

  • 🐛 Use patch level version in go.mod files

/kind bug

Using the patch level version in go.mod file, sets a minimal required Go version for the project, and resolves some issues around the Go tooling, and allows not to use the toolchain directive which introduces a noise in the PRs.

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 5, 2024
@knative-prow knative-prow bot requested review from dsimansk and rhuss November 5, 2024 10:13
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.16%. Comparing base (fe27505) to head (0a26790).
Report is 1 commits behind head on release-1.15.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.15     #385      +/-   ##
================================================
- Coverage         55.67%   53.16%   -2.52%     
================================================
  Files                51       51              
  Lines              1374     1580     +206     
================================================
+ Hits                765      840      +75     
- Misses              540      671     +131     
  Partials             69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardil
Copy link
Contributor Author

cardil commented Nov 5, 2024

/override "Mage / Build (1.22)"

Copy link

knative-prow bot commented Nov 5, 2024

@cardil: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Mage / Build (1.22)

Only the following failed contexts/checkruns were expected:

  • Build (1.22)
  • EasyCLA
  • build-tests_kn-plugin-event_release-1.15
  • codecov/project
  • integration-tests_kn-plugin-event_release-1.15
  • style / Golang
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_kn-plugin-event_release-1.15

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Mage / Build (1.22)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil
Copy link
Contributor Author

cardil commented Nov 5, 2024

/override "Build (1.22)"

Some GH rate limiting kicked on the mage build.

Copy link

knative-prow bot commented Nov 5, 2024

@cardil: Overrode contexts on behalf of cardil: Build (1.22)

In response to this:

/override "Build (1.22)"

Some GH rate limiting kicked on the mage build.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cardil cardil changed the title 🐛 Use patch level version in go.mod files [release-1.15] 🐛 Use patch level version in go.mod files Nov 5, 2024
Copy link

linux-foundation-easycla bot commented Nov 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cardil / name: Chris Suszynski (0a26790)

@knative-prow knative-prow bot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
@cardil cardil force-pushed the bugfix/1.15/gomod-patch-lvl branch from baa73cf to 0a26790 Compare November 5, 2024 10:33
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 5, 2024
@cardil
Copy link
Contributor Author

cardil commented Nov 5, 2024

/override codecov/project

The drop in coverage is weird, looks like a quirk of coverage gather.

Copy link

knative-prow bot commented Nov 5, 2024

@cardil: Overrode contexts on behalf of cardil: codecov/project

In response to this:

/override codecov/project

The drop in coverage is weird, looks like a quirk of coverage gather.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

dsimansk commented Nov 7, 2024

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2024
Copy link

knative-prow bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b96754e into knative-extensions:release-1.15 Nov 7, 2024
33 of 34 checks passed
@cardil cardil deleted the bugfix/1.15/gomod-patch-lvl branch November 7, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants