-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.15] 🐛 Use patch level version in go.mod files #385
[release-1.15] 🐛 Use patch level version in go.mod files #385
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.15 #385 +/- ##
================================================
- Coverage 55.67% 53.16% -2.52%
================================================
Files 51 51
Lines 1374 1580 +206
================================================
+ Hits 765 840 +75
- Misses 540 671 +131
Partials 69 69 ☔ View full report in Codecov by Sentry. |
/override "Mage / Build (1.22)" |
@cardil: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "Build (1.22)" Some GH rate limiting kicked on the mage build. |
@cardil: Overrode contexts on behalf of cardil: Build (1.22) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
baa73cf
to
0a26790
Compare
/override codecov/project The drop in coverage is weird, looks like a quirk of coverage gather. |
@cardil: Overrode contexts on behalf of cardil: codecov/project In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b96754e
into
knative-extensions:release-1.15
Changes
/kind bug
Using the patch level version in
go.mod
file, sets a minimal required Go version for the project, and resolves some issues around the Go tooling, and allows not to use thetoolchain
directive which introduces a noise in the PRs.