Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CORS policy to config-contour #1069

Merged
merged 13 commits into from
Apr 10, 2024
Merged

Add CORS policy to config-contour #1069

merged 13 commits into from
Apr 10, 2024

Conversation

izabelacg
Copy link
Member

Changes

  • add corsPolicy property to config-contour to allow corsPolicy configuration flow into HTTPProxies

@knative-prow knative-prow bot requested review from dprotaso and ReToCode April 3, 2024 19:20
@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 3, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (820cd7c) to head (469bedc).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1069      +/-   ##
==========================================
- Coverage   94.06%   93.92%   -0.14%     
==========================================
  Files          11       11              
  Lines         893      708     -185     
==========================================
- Hits          840      665     -175     
+ Misses         32       22      -10     
  Partials       21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dprotaso
dprotaso reviewed Apr 4, 2024
View reviewed changes
pkg/reconciler/contour/config/contour.go Outdated Show resolved Hide resolved
pkg/reconciler/contour/config/contour.go Outdated Show resolved Hide resolved
pkg/reconciler/contour/config/contour.go Outdated Show resolved Hide resolved
pkg/reconciler/contour/config/contour.go Outdated Show resolved Hide resolved
pkg/reconciler/contour/resources/httpproxy.go Outdated Show resolved Hide resolved
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 4, 2024
@izabelacg
Copy link
Member Author

/hold for others to review

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 4, 2024
@krsna-m
Copy link
Contributor

krsna-m commented Apr 8, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2024
dprotaso
dprotaso reviewed Apr 10, 2024
View reviewed changes
pkg/reconciler/contour/config/contour.go Show resolved Hide resolved
pkg/reconciler/contour/config/contour.go Outdated Show resolved Hide resolved
pkg/reconciler/contour/config/contour.go Outdated Show resolved Hide resolved
pkg/reconciler/contour/resources/httpproxy.go Outdated Show resolved Hide resolved
izabelacg and others added 2 commits April 10, 2024 09:43
@izabelacg @dprotaso
Improve httpproxy with corspolicy condition statement
0cc79b7 
Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
@krsna-m
Better errors
7324add
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 10, 2024
@krsna-m @dprotaso
Update pkg/reconciler/contour/config/contour.go
6ff0470 
Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
@dprotaso
Copy link
Contributor

See the check

Code Style / style / Golang / Auto-format and Check

@dprotaso
Copy link
Contributor

thanks 🎉
/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f2e1c5e into knative-extensions:main Apr 10, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@KauzClay KauzClay KauzClay left review comments

@krsna-m krsna-m krsna-m left review comments

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@izabelacg @krsna-m @dprotaso @KauzClay