Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Contour to v1.28.2 #1072

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

izabelacg
Copy link
Member

Changes

  • Bump Contour to v1.28.2

Resolves #1068

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 9, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto April 9, 2024 18:02
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2024
@izabelacg
Copy link
Member Author

/hold for others

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2024
@izabelacg izabelacg requested a review from dprotaso April 9, 2024 18:03
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (820cd7c) to head (8480309).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1072      +/-   ##
==========================================
- Coverage   94.06%   93.69%   -0.37%     
==========================================
  Files          11       11              
  Lines         893      682     -211     
==========================================
- Hits          840      639     -201     
+ Misses         32       22      -10     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
Copy link

knative-prow bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Contributor

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2024
@dprotaso
Copy link
Contributor

Error from server (InternalError): error when retrieving current configuration of:
Resource: "/v1, Resource=namespaces", GroupVersionKind: "/v1, Kind=Namespace"
Name: "contour-external", Namespace: ""
from server for: "STDIN": an error on the server ("Internal Server Error: "/api/v1/namespaces/contour-external": the server is currently unable to handle the request") has prevented the request from succeeding (get namespaces contour-external)

ugh GKE

/retest

@knative-prow knative-prow bot merged commit e8528f8 into knative-extensions:main Apr 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump contour to v1.28.2
2 participants