Skip to content

Fix plugin inlining that uses client-pkg dependency #2268

Fix plugin inlining that uses client-pkg dependency

Fix plugin inlining that uses client-pkg dependency #2268

Triggered via pull request July 13, 2023 14:14
Status Failure
Total duration 4m 39s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
3s
style / changes
style  /  ...  /  Auto-format and Check
29s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
4m 15s
style / Golang / Lint
style  /  ...  /  Do Not Submit
8s
style / Golang / Do Not Submit
style  /  ...  /  shell
11s
style / suggester / shell
style  /  ...  /  yaml
0s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 10 warnings
style / Golang / Auto-format and Check: pkg/kn/plugin/manager.go#L1
Please run goimports. diff --git a/pkg/kn/plugin/manager.go b/pkg/kn/plugin/manager.go index c1a73a1..df8d852 100644 --- a/pkg/kn/plugin/manager.go +++ b/pkg/kn/plugin/manager.go @@ -17,7 +17,6 @@ package plugin import ( "errors" "fmt" - pkgplugin "knative.dev/client-pkg/pkg/kn/plugin" "os" "os/exec" "path/filepath" @@ -26,6 +25,8 @@ import ( "strings" "text/template" + pkgplugin "knative.dev/client-pkg/pkg/kn/plugin" + homedir "github.com/mitchellh/go-homedir" "github.com/spf13/cobra" )
style / Golang / Auto-format and Check
Process completed with exit code 1.
style / Golang / Boilerplate Check (sh)
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
style / Golang / Boilerplate Check (sh)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum
style / Golang / Boilerplate Check (go)
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
style / Golang / Boilerplate Check (go)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum
style / Golang / Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
style / Golang / Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum