Context Sharing POC #2388
Triggered via pull request
September 21, 2023 13:21
dsimansk
Status
Failure
Total duration
3m 48s
Artifacts
–
knative-style.yaml
on: pull_request
style
/
changes
3s
style
/
...
/
Auto-format and Check
19s
style
/
...
/
Lint
3m 29s
style
/
...
/
Do Not Submit
7s
style
/
...
/
shell
0s
style
/
...
/
yaml
28s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
6 errors and 10 warnings
|
style / Golang / Auto-format and Check:
cmd/kn/main_test.go#L1
Please run goimports.
diff --git a/cmd/kn/main_test.go b/cmd/kn/main_test.go
index c2746a2..f535d28 100644
--- a/cmd/kn/main_test.go
+++ b/cmd/kn/main_test.go
@@ -21,8 +21,6 @@ import (
"strings"
"testing"
- "knative.dev/client/pkg/kn/plugin"
-
"github.com/spf13/cobra"
"gotest.tools/v3/assert"
|
|
style / Golang / Auto-format and Check
Process completed with exit code 1.
|
|
style / Golang / Lint:
pkg/kn/config/config.go#L60
field `contextSharing` is unused (unused)
|
|
style / Golang / Lint:
pkg/kn/plugin/context_sharing.go#L126
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
|
|
style / Golang / Lint:
pkg/kn/plugin/context_sharing.go#L121
SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
|
|
style / Golang / Lint
issues found
|
|
style / Golang / Boilerplate Check (sh)
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
style / Golang / Boilerplate Check (sh)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum
|
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum
|
|
style / Golang / Boilerplate Check (go)
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
style / Golang / Boilerplate Check (go)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum
|
|
style / Golang / Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
style / Golang / Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/client/client. Supported file pattern: go.sum
|