Fix broker condition check #1820
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
![knative-prow[bot]](https://avatars.githubusercontent.com/in/183726?s=60&v=4){kind=small}
There was a problem hiding this comment.
@dsimansk: 0 warnings.
In response to this:
Description
This's changed on the Eventing end with latest nightly versions.
Changes
- Fix broker condition check
Reference
Fixes #
Release Note
NONE
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow
bot
added
the
size/XS
lib/test/eventtype.go
Outdated
| @@ -44,7 +44,7 @@ func EventtypeList(r *KnRunResultCollector, eventtypes ...string) { | |||
| func EventtypeDescribe(r *KnRunResultCollector, name string) { | |||
| out := r.KnTest().Kn().Run("eventtype", "describe", name) | |||
| r.AssertNoError(out) | |||
| assert.Check(r.T(), util.ContainsAll(out.Stdout, name, r.KnTest().Kn().Namespace(), "Ready", "BrokerReady")) | |||
| assert.Check(r.T(), util.ContainsAll(out.Stdout, name, r.KnTest().Kn().Namespace(), "Ready", "BrokerExists")) | |||
There was a problem hiding this comment.
It should be ReferenceExists:
https://github.com/knative/eventing/blob/main/pkg/apis/eventing/v1beta2/eventtype_lifecycle.go#L27
Since the v1beta2 version is using a KReference, which basically allows us to point to any KResource in that sense
There was a problem hiding this comment.
Yep, I'll do the switch in a follow-up PR.
There was a problem hiding this comment.
I see the default broker is gone and that's probably another problem for this test. I'll refactor to v1beta2 a bit sooner than a follow-up PR. :)
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1820 +/- ##
=======================================
Coverage 79.70% 79.70%
=======================================
Files 179 179
Lines 13850 13850
=======================================
Hits 11039 11039
Misses 2050 2050
Partials 761 761 ☔ View full report in Codecov by Sentry. |
|
@vyasgun if you may pls. |
|
/lgtm |
Description
This's changed on the Eventing end with latest nightly versions.
/cc @vyasgun @rhuss
Changes
Reference
Fixes #
Release Note