Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove e2e skip flags after release #1839

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Aug 2, 2023

Description

Changes

  • Remove e2e skip flags after release

Per the PR reviews last week, removing unneeded skips.
/cc @rhuss

Release Note

NONE

@knative-prow knative-prow bot requested a review from rhuss August 2, 2023 13:14
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 2, 2023
@rhuss
Copy link
Contributor

rhuss commented Aug 2, 2023

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b7508e6) 79.67% compared to head (0a21346) 79.67%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1839   +/-   ##
=======================================
  Coverage   79.67%   79.67%           
=======================================
  Files         179      179           
  Lines       13938    13938           
=======================================
  Hits        11105    11105           
  Misses       2067     2067           
  Partials      766      766           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit db8514c into knative:main Aug 2, 2023
17 checks passed
@dsimansk dsimansk deleted the pr/post-release-cleanup branch August 2, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants