Fold in knative.dev/client-pkg as a submodule

[cardil]

Description

This PR merges code from the knative.dev/client-pkg, that is missing in this repo, onto the knative.dev/client/pkg. TBD a PR to deprecate the whole of the knative.dev/client-pkg.

Changes

• 🧹 This PR merges code from the knative.dev/client-pkg, that is missing in this repo, onto the knative.dev/client/pkg
• 🧹 Publicize the code in lib/ dir onto pkg/
• 🧹 Remove the extra kn sub-package
• 🧹 Makes pkg/ as a Go submodule and introduces Go's workspace.

Reference

Fixes #1941
Closes #1935
Closes knative/client-pkg#177
Requires knative/hack#386

Release Note

The knative.dev/client-pkg package is now deprecated in favor of the knative.dev/client/pkg package.

[knative-prow]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[knative-prow]

@cardil: 1 warning.

In response to this:

Description

This PR merges code from the knative.dev/client-pkg, that is missing in this repo, onto the knative.dev/client/pkg. TBD a PR to deprecate the whole of the knative.dev/client-pkg.

Changes

• 🧹 This PR merges code from the knative.dev/client-pkg, that is missing in this repo, onto the knative.dev/client/pkg
• 🧹 Publicize the code in lib/ dir onto pkg/
• 🧹 Remove the extra kn sub-package
• 🧹 Makes pkg/ as a Go submodule and introduces Go's workspace.

Reference

Fixes #1941

Release Note

The [knative.dev/client-pkg](https://pkg.go.dev/knative.dev/client-pkg) is now deprecated in favor of the [knative.dev/client/pkg](https://pkg.go.dev/knative.dev/client/pkg) module.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[dsimansk]

/test all

[codecov]

Codecov Report

Attention: Patch coverage is 50.75758% with 260 lines in your changes missing coverage. Please review.

Project coverage is 75.78%. Comparing base (bb1f899) to head (8ddab3c).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/output/tui/progress.go	0.00%	148 Missing ⚠️
pkg/output/logging/context.go	82.95%	11 Missing and 4 partials ⚠️
pkg/context/wrapper.go	0.00%	14 Missing ⚠️
pkg/output/tui/choose.go	0.00%	14 Missing ⚠️
pkg/output/printer.go	0.00%	12 Missing ⚠️
pkg/output/logging/zap.go	0.00%	9 Missing ⚠️
pkg/config/dir/local.go	76.92%	3 Missing and 3 partials ⚠️
pkg/output/logging/logfile.go	80.00%	3 Missing and 3 partials ⚠️
pkg/output/testing.go	78.57%	4 Missing and 2 partials ⚠️
pkg/output/tui/spinner.go	86.66%	3 Missing and 3 partials ⚠️
... and 9 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1953      +/-   ##
==========================================
- Coverage   76.82%   75.78%   -1.05%     
==========================================
  Files         207      228      +21     
  Lines       12892    13411     +519     
==========================================
+ Hits         9904    10163     +259     
- Misses       2187     2425     +238     
- Partials      801      823      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cardil]

/test all

[cardil]

/test all

[cardil]

/test build-tests

[cardil]

/test unit-tests

[cardil]

/test all

[cardil]

/test all

[cardil]

Looks like both the github action and the prow tests run just for the main module, not for the pkg:

1. https://github.com/knative/client/actions/runs/10639800469/job/29498455266?pr=1953
2. https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_client/1953/unit-tests_client_main/1829644085225328640

[dsimansk]

Looks like both the github action and the prow tests run just for the main module, not for the pkg:

1. https://github.com/knative/client/actions/runs/10639800469/job/29498455266?pr=1953
2. https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_client/1953/unit-tests_client_main/1829644085225328640

Should we go we default implementation of unit tests parsing per go module?
https://github.com/knative/client/blob/main/test/presubmit-tests.sh#L54-L57

[cardil]

Should we go we default implementation of unit tests parsing per go module? https://github.com/knative/client/blob/main/test/presubmit-tests.sh#L54-L57

Great catch @dsimansk!

Apart from the above, we need to fix the GitHub Action, as it is the one to publish coverage to Codecov:

https://github.com/knative/actions/blob/8d6af971ff477fdd929367f4c33c865ba0082b13/.github/workflows/reusable-go-test.yaml#L55-L56

[dsimansk]

/approve
/lgtm

Thanks a lot @cardil!

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dsimansk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dsimansk]

/unhold

[cardil]

Maybe I'll do the last one test, before merging - to try using the PKG package in another repo.

[dsimansk]

/hold

[cardil]

The knative-extensions/kn-plugin-event#366 looks to work with this structure without any hiccups.

/hold cancel