🧹 Remove the vendor dir #1962
🧹 Remove the vendor dir #1962
Conversation
knative-prow
bot
added
kind/cleanup
![knative-prow[bot]](https://avatars.githubusercontent.com/in/183726?s=60&v=4){kind=small}
There was a problem hiding this comment.
@cardil: 1 warning.
In response to this:
Description
Remove the vendor dir. This should simplify the review of #1953
Changes
- 🧹 Remove the vendor dir
/kind cleanup
Reference
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1962 +/- ##
=======================================
Coverage 76.82% 76.82%
=======================================
Files 207 207
Lines 12892 12892
=======================================
Hits 9904 9904
Misses 2187 2187
Partials 801 801 ☔ View full report in Codecov by Sentry. |
knative-prow
bot
requested review from
davidhadas,
itsmurugappan and
maximilien
cardil
force-pushed
the
chore/rm-vendor
branch
3 times, most recently
from
67390bb
to
35da86e
Compare
|
/override "style / Golang / Lint" |
|
@cardil: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "style / Golang / Lint" |
|
@cardil: Overrode contexts on behalf of cardil: style / Golang / Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
knative-prow-robot
added
the
needs-rebase
cardil
force-pushed
the
chore/rm-vendor
branch
from
35da86e
to
ebfdfb7
Compare
knative-prow-robot
removed
the
needs-rebase
cardil
force-pushed
the
chore/rm-vendor
branch
from
ebfdfb7
to
39b861d
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/override "style / Golang / Lint" |
|
@dsimansk: Overrode contexts on behalf of dsimansk: style / Golang / Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Remove the vendor dir. This should simplify the review of #1953
Changes
/kind cleanup
Reference
Simplify #1953
Closes #1959