Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve startup probe hint about progress deadline #6091

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Aug 9, 2024

Proposed Changes

  • Improves the hint about progress deadline seconds in startup probe docs

Copy link

knative-prow bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from mmejia02 and skonto August 9, 2024 08:23
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2024
Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f6f7dee
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66b5d2191d3e310008ac95ea
😎 Deploy Preview https://deploy-preview-6091--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ReToCode
Copy link
Member Author

ReToCode commented Aug 9, 2024

/cherry-pick release-1.15

@knative-prow-robot
Copy link
Contributor

@ReToCode: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ReToCode
Copy link
Member Author

ReToCode commented Aug 9, 2024

/assign @mgencur

@mgencur
Copy link
Contributor

mgencur commented Aug 9, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
@knative-prow knative-prow bot merged commit 0ff0007 into knative:main Aug 9, 2024
19 checks passed
@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #6092

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants