Add support to ignore request in metrics #6177
Conversation
The committers listed above are authorized under a signed CLA. |
|
Welcome @jan-stanek! It looks like this is your first PR to knative/docs 🎉 |
knative-prow
bot
added
the
size/XS
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
jan-stanek
force-pushed
the
ignore-metrics
branch
from
389810a to
74cf40b
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jan-stanek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -19,6 +19,9 @@ Requests endpoint. | |||
| !!! note | |||
| The `revision_queue_depth` metric will be exported only if the revision concurrency hard limit is set to a value greater than 1. | |||
|
|
|||
| !!! note | |||
| To exclude request from metrics (e.g. health check requests), set the `K-Ignore-Metrics` header to non-empty value. | |||
There was a problem hiding this comment.
What are the security implications of this header? I'm concerned that someone could use this header to sneak in a DDoS attack that wouldn't show up on monitoring.
There was a problem hiding this comment.
Good point, would it be better to have possibility to specify additional label for metrics?
|
/hold |
knative-prow
bot
added
the
do-not-merge/hold
Proposed Changes
K-Ignore-Metrics