Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cert manager test is running the wrong tests disable it for now #442

Merged
merged 1 commit into from
May 23, 2024

Conversation

dprotaso
Copy link
Member

@knative-prow knative-prow bot requested review from krsna-m and upodroid May 23, 2024 01:56
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2024
@dprotaso
Copy link
Member Author

/assign @skonto

@dprotaso dprotaso force-pushed the make-certmanager-test-optional branch from 94b3990 to 57e0ddb Compare May 23, 2024 02:04
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2024
@dprotaso dprotaso changed the title cert manager test is flakey make it optional cert manager test is running the wrong tests disable it for now May 23, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
Copy link

knative-prow bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9b8fc25 into knative:main May 23, 2024
17 checks passed
Copy link

knative-prow bot commented May 23, 2024

@dprotaso: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key serving-main.gen.yaml using file prow/jobs/generated/knative/serving-main.gen.yaml

In response to this:

Part of knative/serving#15236

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants